Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kmail: add akonadi to propagated user env #68386

Merged
merged 1 commit into from Sep 15, 2019
Merged

kmail: add akonadi to propagated user env #68386

merged 1 commit into from Sep 15, 2019

Conversation

nyanloutre
Copy link
Member

Motivation for this change

Kmail will not work if akonadi is not in the PATH

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@nyanloutre
kmail: add akonadi to propagated user env
8d0af1f 
Kmail will not work if akonadi is not in the PATH
@ofborg ofborg bot requested a review from vandenoever September 9, 2019 22:15
@vandenoever
Copy link
Contributor

In release-19.03, kmail.nix does not include akonadi, but it's available on the path when installing kmail anyway. What has changed?

@lheckemann lheckemann added this to the 19.09 milestone Sep 10, 2019
@ttuegel
Copy link
Member

ttuegel commented Sep 15, 2019

What has changed?

KDE packages no longer propagate every dependency to the user environment.

@ttuegel ttuegel merged commit db9838e into NixOS:master Sep 15, 2019
@nyanloutre nyanloutre deleted the kmail_akonadi_usr_env branch September 16, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

@vandenoever vandenoever Awaiting requested review from vandenoever

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nyanloutre @vandenoever @ttuegel @lheckemann