Import victor's layout system 🍷 #24165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up! This PR modifies the following files:
|
|
|
SimonSapin
force-pushed
the
victor
branch
2 times, most recently
from
d159564
to
a7526ba
Compare
emilio
reviewed
Sep 10, 2019
| @@ -352,12 +393,14 @@ impl Display { | |||
| match self.outside() { | |||
| DisplayOutside::Inline => { | |||
| let inside = match self.inside() { | |||
| #[cfg(any(feature = "servo-layout-2013", feature = "gecko"))] | |||
There was a problem hiding this comment.
#[cfg]ing this out is wrong, why?
There was a problem hiding this comment.
I can't keep it, I removed DisplayInside::Block and DisplayInside::Inline. Those are hacks to make layout supposedly easier, but it's just hindering layout 2020.
There was a problem hiding this comment.
I added back a blockification which makes it store DisplayInside::FlowRoot with servo-layout-2020.
There was a problem hiding this comment.
Err, I meant I made it store DisplayInline::Flow, sorry.
SimonSapin
reviewed
Sep 10, 2019
|
r+ with nits Thanks @nox! |
It doesn't construct flows anymore.
|
@bors-servo r=SimonSapin |
|
📌 Commit 4444c5a has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Sep 11, 2019
Import victor's layout system 🍷 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24165) <!-- Reviewable:end -->
|
☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster |
highfive
removed
the
S-awaiting-merge
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 13, 2019
servo/servo#24165 Differential Revision: https://phabricator.services.mozilla.com/D45740 --HG-- extra : moz-landing-system : lando
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Sep 13, 2019
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
servo/servo#24165 Differential Revision: https://phabricator.services.mozilla.com/D45740 UltraBlame original commit: ff80bc57d655e8da75c74e99830ff3346c0bbb1c
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
servo/servo#24165 Differential Revision: https://phabricator.services.mozilla.com/D45740 UltraBlame original commit: ff80bc57d655e8da75c74e99830ff3346c0bbb1c
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
servo/servo#24165 Differential Revision: https://phabricator.services.mozilla.com/D45740 UltraBlame original commit: ff80bc57d655e8da75c74e99830ff3346c0bbb1c
SimonSapin
added
the
A-layout/2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is