Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/zabbixWeb: fix a string reference as well as the phpfpm socket path #68365

Merged
merged 1 commit into from
Sep 12, 2019
Merged

nixos/zabbixWeb: fix a string reference as well as the phpfpm socket path #68365

merged 1 commit into from
Sep 12, 2019
+2 −2

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Sep 9, 2019

Motivation for this change

Minor fallout from #65706. I have tested this against a system on latest built nixos-unstable checkout so shouldn't be any problems this time. Note that a zabbix test would still be appreciated to alleviate manual testing and more quickly catch problems like this. @mmahut 😉

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mmahut @etu

Sorry, something went wrong.

@aanderse aanderse requested review from etu and mmahut September 9, 2019 16:30
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 9, 2019
@lheckemann lheckemann added this to the 19.09 milestone Sep 10, 2019
@mmahut
Copy link
Member

mmahut commented Sep 12, 2019

Oh, these zabbix tests - soon. :)

@mmahut mmahut merged commit f16bc2f into NixOS:master Sep 12, 2019
@mmahut mmahut mentioned this pull request Sep 12, 2019
Merged
10 tasks
@aanderse aanderse deleted the zabbix branch September 12, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu

@mmahut mmahut

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @mmahut @lheckemann