Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix desktop tests #68392

Merged
merged 5 commits into from Sep 11, 2019
Merged

Fix desktop tests #68392

merged 5 commits into from Sep 11, 2019

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Sep 10, 2019

Motivation for this change

https://hydra.nixos.org/build/100471962
https://hydra.nixos.org/build/100471851
https://hydra.nixos.org/build/100472011

A lot of these tests, though strangely not all, were failing at the

$machine->succeed("getfacl /dev/snd/timer | grep -q alice");

step which seems to also be done in the login test.

The same issue popped up there so I duplicated the fix f59b4cb.
In general all these tests could be nicer.

I also took the liberty to bump the memorySize for the xfce tests 5b42b1f 9f43d80 to what all the other desktop tests have.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Contributor Author

cc @andir as you authored f59b4cb and systemd bump.

@andir
Copy link
Member

andir commented Sep 10, 2019

I do wonder if we shouldn't default sound to enabled when a DE is activated.

@worldofpeace
Copy link
Contributor Author

Just realized that certain DE's enable pulseaudio which in turn enables sound. Probably why in certain cases it wasn't failing.

I do wonder if we shouldn't default sound to enabled when a DE is activated.

It's only like that for certain modules with pulseaudio.

@worldofpeace
Copy link
Contributor Author

I've opted to just enable pulseaudio in those particular tests.

@worldofpeace worldofpeace added this to the 19.09 milestone Sep 10, 2019
@worldofpeace worldofpeace merged commit 64b11eb into NixOS:master Sep 11, 2019
@worldofpeace worldofpeace deleted the fix-desktop-tests branch September 11, 2019 06:34
@worldofpeace
Copy link
Contributor Author

backported in b0e3673...c6332a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants