Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://hydra.nixos.org/build/100471962
https://hydra.nixos.org/build/100471851
https://hydra.nixos.org/build/100472011
A lot of these tests, though strangely not all, were failing at the
step which seems to also be done in the login test.
The same issue popped up there so I duplicated the fix f59b4cb.
In general all these tests could be nicer.
I also took the liberty to bump the
memorySize
for the xfce tests 5b42b1f 9f43d80 to what all the other desktop tests have.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @