ghc: compile with DWARF support by default #68362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenkozar
force-pushed
the
ghc-dwarf
branch
from
19c1c1e
to
f92cb22
Compare
domenkozar
requested review from
adisbladis,
alyssais,
FRidh,
infinisil,
matthewbauer,
ttuegel and
zimbatm
as code owners
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
labels
|
CI failure doesn't come from this PR. |
This allows our GHCs to build programs with DWARF debug information when -g is passed, see https://ghc.haskell.org/trac/ghc/wiki/DWARF. Compiling with debug symbols is off by default until GHC ticket NixOS#15960 (Using -g causes differences in generated core) is fixed.
domenkozar
force-pushed
the
ghc-dwarf
branch
from
f92cb22
to
769c65b
Compare
|
I hoped this would go to 19.09 as it's really a small change, but crucial for Haskell in production. |
|
No problem, this change can still make it into 19.09. I'll run the necessary test builds, and then it will be part of my Haskell Infrastructure sync. |
|
Thank you @peti <3 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows our GHCs to build programs with DWARF debug information
when -g is passed, see https://ghc.haskell.org/trac/ghc/wiki/DWARF.
Compiling with debug symbols is off by default until GHC ticket #15960
(Using -g causes differences in generated core) is fixed.
This differs with #52255 which makes the whole support optional and instead exposes another package set, which was brought up as problematic.