Skip to content

rtl8812au: fix cross compiling and enable arm support #76967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2020
Merged

rtl8812au: fix cross compiling and enable arm support #76967

merged 1 commit into from
Feb 10, 2020
+10 −1

Conversation

danielfullmer
Copy link
Contributor

Built and tested on:
Raspberry Pi 3, natively compiled on aarch64
Raspberry Pi 1, cross compiled from x86_64 to armv6l

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

I am the maintainer.

CC also the maintainer of rtl8821au as well, since the packages are very similar: @plchldr

Sorry, something went wrong.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Jan 5, 2020
@danielfullmer
rtl8812au: fix cross compiling
dd9410c 
Built and tested on:
Raspberry Pi 3, natively compiled on aarch64
Raspberry Pi 1, cross compiled from x86_64 to armv6l
@danielfullmer
Copy link
Contributor Author

Also tested working on my pinebook pro (aarch64)

@FRidh FRidh merged commit 51950d7 into NixOS:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielfullmer @FRidh