Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.tensorflow: fix build with cudatoolkit 10.2 #76945

Merged
merged 1 commit into from Jan 6, 2020
Merged

python.pkgs.tensorflow: fix build with cudatoolkit 10.2 #76945

merged 1 commit into from Jan 6, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jan 4, 2020 •
edited

Motivation for this change

This fixes the tensorflow package build failure.

Before the change the build with cudatoolkit 10.2 (now default) fails with the following error:

ERROR: /build/output/external/nccl_archive/BUILD.bazel:53:1: fatbinary external/nccl_archive/device_dlink_hdrs.fatbin failed (Exit 1)
fatbinary fatal   : Unknown option '-bin2c-path'

As tensorflow/tensorflow#34429 suggests, the fix is to drop the option from the build_defs.bzl.tpl script.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @timokau

@prusnak prusnak mentioned this pull request Jan 4, 2020
Closed
@ofborg ofborg bot requested a review from abbradar January 4, 2020 18:52
timokau
timokau requested changes Jan 5, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to the upstream issue as a comment where you include the patch.

@prusnak prusnak requested a review from timokau January 6, 2020 15:35
@timokau
Copy link
Member

timokau commented Jan 6, 2020

Thank you!

@timokau timokau merged commit bdbec90 into NixOS:master Jan 6, 2020
@prusnak prusnak deleted the tensorflow-drop-bin2c-path branch January 6, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @timokau