go_1_12, go_1_13: skip TestExtraFiles on 32-bit arm #76944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefloweringash
force-pushed
the
go-flaky-test-extra-files-arm
branch
from
4aeb516
to
be738a0
Compare
thefloweringash
changed the title
The test is known to be flaky in some environments, and I'm seeing it consistently in an armv7l-linux vm.
thefloweringash
force-pushed
the
go-flaky-test-extra-files-arm
branch
from
be738a0
to
6657ec8
Compare
kalbasit
approved these changes
Jan 10, 2020
10 tasks
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Jan 27, 2020
The test is known to be flaky in some environments, and I'm seeing it consistently in an armv7l-linux vm. (cherry picked from commit ffd68f2)
Frostman
pushed a commit
to Frostman/nixpkgs
that referenced
this pull request
Feb 8, 2020
The test is known to be flaky in some environments, and I'm seeing it consistently in an armv7l-linux vm. (cherry picked from commit ffd68f2)
pull bot
pushed a commit
to Frostman/nixpkgs
that referenced
this pull request
Feb 12, 2020
The test is known to be flaky in some environments, and I'm seeing it consistently in an armv7l-linux vm. (cherry picked from commit ffd68f2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The test is known to be flaky in some environments, and I'm seeing it
consistently in an armv7l-linux vm.
Note that to test this the contents of the following PRs are required:
And it will likely fail to build due to golang/go#32738, which will be fixed in go 1.14.
The patch to disable the test is duplicated to avoid a mass rebuild on other platforms.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @