Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebIDL: [PutForwards] should not throw if [[Set]] has failed #21039

Merged
merged 1 commit into from Jan 15, 2020
Merged

WebIDL: [PutForwards] should not throw if [[Set]] has failed #21039

merged 1 commit into from Jan 15, 2020

Conversation

shvaikalesh
Copy link
Member

yuki3
yuki3 approved these changes Jan 4, 2020
View reviewed changes
Copy link
Member

@yuki3 yuki3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

TimothyGu
TimothyGu requested changes Jan 9, 2020
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment •
edited by bzbarsky

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, doesn't look like Chrome or Firefox implements Throw = true. Maybe the better fix here would be to change the spec to say

Perform ? Set(Q, forwardId, V, false).

instead.

TimothyGu added a commit to TimothyGu/webidl that referenced this pull request Jan 14, 2020
@TimothyGu
Call Set with Throw=false for [PutForwards]
bd48fcd 
This is what browsers actually implement. Tested by
web-platform-tests/wpt#21039.
@TimothyGu TimothyGu mentioned this pull request Jan 14, 2020
Merged
@TimothyGu
Copy link
Member

See whatwg/webidl#832.

bzbarsky pushed a commit to whatwg/webidl that referenced this pull request Jan 14, 2020
@TimothyGu @bzbarsky
Call Set with Throw=false for [PutForwards] (#832)
d93ee24 
This is what browsers actually implement. Tested by
web-platform-tests/wpt#21039.
@shvaikalesh @TimothyGu
WebIDL: [PutForwards] should not throw if [[Set]] has failed
dea071a 
This tests whatwg/webidl#832.

Co-authored-by: Timothy Gu <timothygu99@gmail.com>
@TimothyGu TimothyGu changed the title WebIDL: [PutForwards] should throw if [[Set]] has failed WebIDL: [PutForwards] should not throw if [[Set]] has failed Jan 15, 2020
@TimothyGu
Copy link
Member

Modified to account for whatwg/webidl#832.

@TimothyGu TimothyGu assigned TimothyGu and unassigned yuki3 Jan 15, 2020
@TimothyGu TimothyGu merged commit 585514a into web-platform-tests:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@yuki3 yuki3 yuki3 approved these changes

@domenic domenic Awaiting requested review from domenic

Assignees

@TimothyGu TimothyGu

Labels
webidl wg-webplatform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shvaikalesh @TimothyGu @yuki3 @wpt-pr-bot