Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

psi-plus: 1.4.904 -> 1.4.983 #76902

Closed
wants to merge 1 commit into from
Closed

psi-plus: 1.4.904 -> 1.4.983 #76902

wants to merge 1 commit into from

Conversation

misuzu
Copy link
Contributor

@misuzu misuzu commented Jan 3, 2020

Motivation for this change

New snapshot: https://github.com/psi-plus/psi-plus-snapshots/releases/tag/1.4.983

Also fix This application failed to start because no Qt platform plugin could be initialized error on startup by including wrapQtAppsHook in nativeBuildInputs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @orivej

@misuzu
psi-plus: 1.4.904 -> 1.4.983
4bdd413 
Also fix 'This application failed to start because no Qt platform plugin could be initialized' error on startup by including wrapQtAppsHook in nativeBuildInputs.
@misuzu
Copy link
Contributor Author

misuzu commented Jan 3, 2020 •
edited

Pretty sure #76705 broke qtkeychain or something else because running git revert -m 1 9ec439e009098b3132848c525a033a602f74faed fixes ld: cannot find -lsecret-1 error.

@misuzu
Copy link
Contributor Author

misuzu commented Jan 13, 2020 •
edited

Superseded by #77612

@misuzu misuzu closed this Jan 13, 2020
@misuzu misuzu deleted the psi-plus-1.4.983 branch January 13, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@misuzu