Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mercurial_4: init at 4.9.1 #76903

Merged
merged 2 commits into from Jan 6, 2020
Merged

mercurial_4: init at 4.9.1 #76903

merged 2 commits into from Jan 6, 2020

Conversation

eraserhd
Copy link
Contributor

@eraserhd eraserhd commented Jan 3, 2020 •
edited

Motivation for this change

Commit 88a473f upgraded mercurial, made it use python3, and removed
support for hg-git, breaking graalvm8. Since hg-git does not
officially support python3 or the new version of mercurial, this
patch adds back the old version of mercurial, used only by the
graalvm build.

Closes #76527.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @eelco @volth @hlolli

@hlolli I assume the 19.2.1 Graal PR will need to be updated as well?

@eraserhd
Copy link
Contributor Author

eraserhd commented Jan 4, 2020 via email

@eraserhd eraserhd changed the title graalvm8: use custom mercurial mercurial4_9: init at 4.9.1 Jan 4, 2020
@eraserhd
Copy link
Contributor Author

eraserhd commented Jan 4, 2020

Alright, made it mercurial4_9, changed the PR title and fixed up the commits.

@ofborg ofborg bot requested review from volth and edolstra January 4, 2020 04:13
FRidh
FRidh requested changes Jan 4, 2020
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/version-management/mercurial/4.9.nix Outdated Show resolved Hide resolved
@eraserhd
mercurial_4: init at 4.9.1
0e12a91
@eraserhd
graalvm8: use mercurial_4
c15f42a 
Commit 88a473f upgraded mercurial, made it use python3, and removed
support for hg-git, breaking graalvm8.  Since hg-git does not
officially support python3 or the new version of mercurial, this
patch uses mercurial_4.

Closes NixOS#76527.
@eraserhd eraserhd changed the title mercurial4_9: init at 4.9.1 mercurial_4: init at 4.9.1 Jan 4, 2020
eraserhd
eraserhd commented Jan 4, 2020
View reviewed changes
Copy link
Contributor Author

@eraserhd eraserhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed up.

@FRidh FRidh merged commit a54461f into NixOS:master Jan 6, 2020
@Artturin
Copy link
Member

Artturin commented Jul 1, 2021 •
edited

any reason why you did

, mercurialSrc ? fetchurl rec {
    meta.name = "mercurial-${meta.version}";
    meta.version = "4.9.1";
    url = "https://mercurial-scm.org/release/${meta.name}.tar.gz";
    sha256 = "0iybbkd9add066729zg01kwz5hhc1s6lhp9rrnsmzq6ihyxj3p8v";
  }

? #128843

@Artturin Artturin mentioned this pull request Jul 1, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@edwtjo edwtjo Awaiting requested review from edwtjo

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

@hlolli hlolli Awaiting requested review from hlolli

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

graalvm8 19.1.1 fails to bulid since mercurial update in 88a473fc12e24ba850ae4b120ae0c766d9dd6840
3 participants
@eraserhd @Artturin @FRidh