Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyramid: cleanup dependencies #76953

Merged
merged 1 commit into from Jan 8, 2020
Merged

pythonPackages.pyramid: cleanup dependencies #76953

merged 1 commit into from Jan 8, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 4, 2020

Motivation for this change

Fixes: #76593
cc: @azazel75

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from domenkozar January 4, 2020 20:36
@marsam
Copy link
Contributor Author

marsam commented Jan 4, 2020

@GrahamcOfBorg build python3Packages.pyramid

@marsam marsam merged commit a6f8ad6 into NixOS:master Jan 8, 2020
@marsam marsam deleted the python-pyramid-cleanup-dependencies branch January 8, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pyramid: make the dependency on Sphinx optional
1 participant
@marsam