Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

precice: fix output and cmake #76937

Merged
merged 1 commit into from Jan 27, 2020
Merged

precice: fix output and cmake #76937

merged 1 commit into from Jan 27, 2020

Conversation

Scriptkiddi
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
Copy link
Contributor

this builds on master for me, what does this try to fix? all i can see is editing the cmake file

@Scriptkiddi
Copy link
Contributor Author

It was building before but I messed up the correct installation paths for the cmake files, this is fixed now I also added a patch for a pr that i opened upstream(precice/precice#605 ) because other wise the cmake files include paths that are not avaliable in nixos and it will fail when including the lib

jtojnar
jtojnar reviewed Jan 6, 2020
View reviewed changes
pkgs/development/libraries/precice/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/precice/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/precice/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/precice/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/precice/default.nix Show resolved Hide resolved
pkgs/development/libraries/precice/default.nix Outdated Show resolved Hide resolved
@Scriptkiddi
Copy link
Contributor Author

@jtojnar all done

@jonringer
Copy link
Contributor

still got build failures

@Scriptkiddi
Copy link
Contributor Author

fixed

@jonringer
Copy link
Contributor

@GrahamcOfBorg build precice

Lassulus
Lassulus approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review

@Lassulus Lassulus merged commit 50f3a9f into NixOS:master Jan 27, 2020
@fsimonis
Copy link

FYI we merged precice/precice#577 and precice/precice#609.
You should not have to patch our CMake files any longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@fsimonis fsimonis fsimonis left review comments

@Lassulus Lassulus Lassulus approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Scriptkiddi @jonringer @fsimonis @Lassulus @jtojnar