Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zerotierone: fix cross compilation #76916

Merged
merged 3 commits into from
Jan 4, 2020
Merged

zerotierone: fix cross compilation #76916

merged 3 commits into from
Jan 4, 2020
+9 −6

Conversation

danielfullmer
Copy link
Contributor

Motivation for this change

Fix for cross compilation. Note that the which dependency was removed upstream in this commit from 2015

Built on x86_64 and tested on raspberry pi 1 with pkgsCross.raspberryPi.zerotierone.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @sjmackenzie @zimbatm @ehmry @obadz

Sorry, something went wrong.

@danielfullmer
zerotierone: fix cross compilation

Verified

This commit was signed with the committer’s verified signature.
etu Elis Hirwing
GPG key ID: D57EFA625C9A925F
Verified
Learn about vigilant mode
44d0aed
@danielfullmer
zerotierone: add danielfullmer as maintainer

Verified

This commit was signed with the committer’s verified signature.
etu Elis Hirwing
GPG key ID: D57EFA625C9A925F
Verified
Learn about vigilant mode
7fffda0
@danielfullmer
zerotierone: add arm platform

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
115534c 
Tested on raspberry pi 1.
@ofborg ofborg bot requested review from zimbatm, obadz and ehmry January 4, 2020 02:12
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 4, 2020
@zimbatm zimbatm merged commit 48f461d into NixOS:master Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry

@zimbatm zimbatm

@obadz obadz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielfullmer @ehmry @zimbatm