Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utsushi: 3.59.2 -> unstable-2020-11-10 #76909

Merged
merged 1 commit into from Nov 14, 2020
Merged

utsushi: 3.59.2 -> unstable-2020-11-10 #76909

merged 1 commit into from Nov 14, 2020

Conversation

wucke13
Copy link
Contributor

@wucke13 wucke13 commented Jan 3, 2020 •
edited

Motivation for this change

Update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@wucke13
Copy link
Contributor Author

wucke13 commented Jan 3, 2020

@GrahamcOfBorg build utsushi

@wucke13 wucke13 changed the title [WIP] utsushi: 3.59.2 -> 3.61.0 utsushi: 3.59.2 -> 3.61.0 Jan 4, 2020
@wucke13 wucke13 changed the title utsushi: 3.59.2 -> 3.61.0 [WIP] utsushi: 3.59.2 -> 3.61.0 Jan 4, 2020
@Lassulus
Copy link
Member

@GrahamcOfBorg build utsushi

@wucke13
Copy link
Contributor Author

wucke13 commented Jan 13, 2020

There still is an issue in the package, that needs to be fixed either through a patch in this PR or through a new release - so please don't merge yet.

@wucke13 wucke13 force-pushed the utsushi branch 2 times, most recently from 8d0ff99 to 2cb3bde Compare February 20, 2020 20:23
@plabadens plabadens mentioned this pull request Aug 5, 2020
Closed
@ryantm ryantm marked this pull request as draft October 23, 2020 03:03
@wucke13 wucke13 changed the title [WIP] utsushi: 3.59.2 -> 3.61.0 utsushi: 3.59.2 -> master Nov 13, 2020
@wucke13
Copy link
Contributor Author

wucke13 commented Nov 13, 2020

@GrahamcOfBorg build utsushi

@wucke13
Copy link
Contributor Author

wucke13 commented Nov 13, 2020

@Lassulus This could finally be ready for merge. Can you remove the Draft status?

@Lassulus
Copy link
Member

Uh you could do that yourself, but master is not really a released version. We really prefer stable released versions upstream. But if you really want to bump this to an unreleased git rev. Then the correct version number would be "unstable-2020-11-11" (the date of the pinned commit)

@wucke13
utsushi: 3.59.2 -> unstable-2020-11-10
f89b4dc 
+ master should be roughly equivalent to 3.62.0
+ moving to the community repo because they are way better at fixing
  things, while upstream epson almost never merges fixes
+ great thanks to @mwilsoncoding for debugging the problem:
   + `autoconf-archive` was missing
@wucke13
Copy link
Contributor Author

wucke13 commented Nov 14, 2020

We had a discussion about this already. Epson releases with version numbers, however, they almost never fix things. There is a community repo which incorporates loads of fixes, but said community repo does not have releases at all, yet. I would opt for the community repo, I'm immediately aware of at least two bugs which are fixed by doing so.

I adjusted the version number accordingly, thank you for that hint @Lassulus 😄

@Lassulus Lassulus marked this pull request as ready for review November 14, 2020 15:10
@Lassulus Lassulus changed the title utsushi: 3.59.2 -> master utsushi: 3.59.2 -> unstable-2020-11-10 Nov 14, 2020
@Lassulus Lassulus merged commit 4d187fc into NixOS:master Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wucke13 @Lassulus @ryantm