New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Push-buttons on storybook pages #7896
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsmh
added
the
component: AI/Game script (squirrel)
This issue is related to Squirrel (Scripting language)
label
Jan 15, 2020
…reference parameter
Just got an idea that it would be quite useful to have buttons that can connect players to other servers. Mostly for commuties that have more than one server. |
michicc
approved these changes
May 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't write a GS to test this, but the code diff itself looks fine to me.
JGRennison
added a commit
to JGRennison/Upstream-OpenTTD
that referenced
this pull request
May 27, 2020
nielsmh
pushed a commit
that referenced
this pull request
May 27, 2020
rasputino
pushed a commit
to rasputino/OpenTTD
that referenced
this pull request
Jun 1, 2020
Allow more direct player-initiated interaction for Game Scripts, by letting the GS put push-buttons on storybook pages. These buttons can either trigger an immediate event, or require the player to first select a tile on the map, or a vehicle. Additionally this reworks how the storybook pages are layouted and rendered, to allow for slightly more complex layouts, and maybe speeding drawing up a bit.
rasputino
pushed a commit
to rasputino/OpenTTD
that referenced
this pull request
Jun 1, 2020
freprec
pushed a commit
to freprec/OpenTTD
that referenced
this pull request
Jun 19, 2020
Allow more direct player-initiated interaction for Game Scripts, by letting the GS put push-buttons on storybook pages. These buttons can either trigger an immediate event, or require the player to first select a tile on the map, or a vehicle. Additionally this reworks how the storybook pages are layouted and rendered, to allow for slightly more complex layouts, and maybe speeding drawing up a bit.
freprec
pushed a commit
to freprec/OpenTTD
that referenced
this pull request
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds three kinds of new elements to storybook pages: A plain instant-action button, a "select a tile" tool button, and a "select a vehicle" tool button.
When a player clicks a button, and selects a tile or vehicle if required, an event is posted to the game script.
This allows for more types of player-initiated interaction with GS.
Ideas not yet implemented, which I'd like feedback on: