Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soapysdr: add as python module #76898

Merged
merged 1 commit into from Jan 5, 2020
Merged

soapysdr: add as python module #76898

merged 1 commit into from Jan 5, 2020

Conversation

markuskowa
Copy link
Member

@markuskowa markuskowa commented Jan 3, 2020 •
edited

Motivation for this change

Use "toPythonModule" function to make python interface available.
So far the python interface was not properly exposed via nixpkgs (closes #76808)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @sbourdeauducq

@markuskowa
soapysdr: add as python module
4097ffc 
Use "toPythonModule" function to make python interface available.
sbourdeauducq
sbourdeauducq approved these changes Jan 5, 2020
View reviewed changes
Copy link
Contributor

@sbourdeauducq sbourdeauducq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine.
Thanks!

@markuskowa markuskowa merged commit 87021d3 into NixOS:master Jan 5, 2020
@markuskowa markuskowa deleted the fix-soapysdr branch January 5, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@sbourdeauducq sbourdeauducq sbourdeauducq approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

soapysdr: Python binding cannot be used
3 participants
@markuskowa @sbourdeauducq @FRidh