Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frescobaldi: 3.0.0 -> 3.1 #76889

Merged
merged 1 commit into from Jan 3, 2020
Merged

frescobaldi: 3.0.0 -> 3.1 #76889

merged 1 commit into from Jan 3, 2020

Conversation

puzzlewolf
Copy link
Contributor

@puzzlewolf puzzlewolf commented Jan 3, 2020 •
edited by veprbl

Motivation for this change

Closes: #76847

3.0.0 does not work #76847 because it needs wrapQtAppsHook.

Also, version 3.1. is available, which replaces QtWebKit with QtWebEngine #53079.

Things done

I modeled the changes after #66796, which fixed the same problem for anki. That change uses pyqtwebengine, so I decided to move frescobaldi to 3.1.

I do not really understand these lines:

  dontWrapQtApps = true;
  makeWrapperArgs = [
      "\${qtWrapperArgs[@]}"
  ];

Without makeWrapperArgs ..., startup fails with the same error as before,

qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""

Without dontWrapQtApps = true, frescobaldi starts. But anki has this line, so, what is it needed for?

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @sepi

@FRidh
Copy link
Member

FRidh commented Jan 3, 2020

please fix the commit title and PR title according the contributing guidelines. Specifically, include the attribute name.

@puzzlewolf puzzlewolf mentioned this pull request Jan 3, 2020
Closed
@puzzlewolf puzzlewolf changed the title 3.0.0 -> 3.1 frescobaldi: 3.0.0 -> 3.1 Jan 3, 2020
@puzzlewolf
Copy link
Contributor Author

puzzlewolf commented Jan 3, 2020 •
edited

Whoops, fixed, thanks for the heads-up.

@veprbl veprbl mentioned this pull request Jan 3, 2020
Closed
69 tasks
veprbl
veprbl approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs on NixOS x86_64-linux

@veprbl veprbl merged commit c5e72fa into NixOS:master Jan 3, 2020
@puzzlewolf puzzlewolf deleted the frescobaldi branch January 3, 2020 22:47
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/frescobaldi-under-hyprland-error-on-startup/30382/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

frescobaldi fails to start
4 participants
@puzzlewolf @FRidh @nixos-discourse @veprbl