Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docbook-xsl: Fix reproducibility when building docs #76955

Merged
merged 1 commit into from Jan 6, 2020
Merged

docbook-xsl: Fix reproducibility when building docs #76955

merged 1 commit into from Jan 6, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jan 4, 2020 •
edited

When building docs generate.consistent.ids was not respected for indexes.

docbook/xslt10-stylesheets#88
https://sourceforge.net/p/docbook/bugs/1385/

This lead to r13y failures in udisks2.devdoc.

  • Verified that docbook-xsl and docbook-xsl-nons build with the patch.

@jtojnar
docbook-xsl: Fix reproducibility when building docs
743f76c 
When building docs generate.consistent.ids was not respected for indexes.

docbook/xslt10-stylesheets#88
https://sourceforge.net/p/docbook/bugs/1385/

This lead to r13y failures in udisks2.devdoc.
grahamc
grahamc approved these changes Jan 4, 2020
View reviewed changes
Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re https://r13y.com/diff/16cb836bbe793a6db868bde324505ecf58bcfbc2001bc5c6e6a6e8f7893e54ac-593f834fdf0449af36cd71489e6c797c3896eecc697033240376389caad19abb.html

jtojnar
jtojnar commented Jan 4, 2020
View reviewed changes
pkgs/data/sgml+xml/stylesheets/xslt/docbook-xsl/default.nix
(fetchpatch {
url = "https://github.com/docbook/xslt10-stylesheets/commit/07631601e6602bc49b8eac3aab9d2b35968d3e7a.patch";
sha256 = "0igfhcr6hzcydqsnjsd181h5yl3drjnrwdmxcybr236m8255vkq3";
stripLen = "1";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stripLen is here because the main directory in the tarball is the xsl directory (renamed).

@ofborg ofborg bot requested a review from edolstra January 4, 2020 22:43
@FRidh FRidh added this to WIP in Staging via automation Jan 6, 2020
@FRidh FRidh merged commit d8369ed into NixOS:staging Jan 6, 2020
Staging automation moved this from WIP to Done Jan 6, 2020
@jtojnar jtojnar deleted the docbook-xsl-r13y branch July 14, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @grahamc @FRidh