Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox: update rust to 1.40.0 #76894

Merged
merged 1 commit into from Jan 7, 2020
Merged

firefox: update rust to 1.40.0 #76894

merged 1 commit into from Jan 7, 2020

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Jan 3, 2020

Motivation for this change

Firefox is built successfully by rustc 1.40.0 and works.
It seems no need to lock on the old rustc now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • 605,645,952 -> 605,719,680
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@lheckemann
Copy link
Member

@ofborg build firefox

@lheckemann lheckemann merged commit bf012bc into NixOS:master Jan 7, 2020
@oxalica oxalica deleted the firefox-bump-rust branch January 7, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oxalica @lheckemann