Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add several python packages #76954

Merged
merged 10 commits into from Jan 6, 2020
Merged

Add several python packages #76954

merged 10 commits into from Jan 6, 2020

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Jan 4, 2020 •
edited

Motivation for this change

Extracting the new packages from the outdated #64962, and replaces #76952.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@kalbasit
Copy link
Member Author

kalbasit commented Jan 4, 2020

@GrahamcOfBorg build h3 python2Packages.h3 python2Packages.timezonefinder python2Packages.snowflake-sqlalchemy python2Packages.snowflake-connector-python python2Packages.oscrypto python2Packages.area python3Packages.h3 python3Packages.timezonefinder python3Packages.snowflake-sqlalchemy python3Packages.snowflake-connector-python python3Packages.oscrypto python3Packages.area

@jonringer
Copy link
Contributor

please resolve conflicts

@kalbasit
Copy link
Member Author

kalbasit commented Jan 6, 2020

@GrahamcOfBorg build h3
@GrahamcOfBorg build python2Packages.h3 python2Packages.timezonefinder python2Packages.snowflake-sqlalchemy python2Packages.snowflake-connector-python python2Packages.oscrypto python2Packages.area
@GrahamcOfBorg build python3Packages.h3 python3Packages.timezonefinder python3Packages.snowflake-sqlalchemy python3Packages.snowflake-connector-python python3Packages.oscrypto python3Packages.area

@kalbasit
Copy link
Member Author

kalbasit commented Jan 6, 2020

@GrahamcOfBorg build h3
@GrahamcOfBorg build python2Packages.h3 python2Packages.timezonefinder python2Packages.snowflake-sqlalchemy python2Packages.snowflake-connector-python python2Packages.oscrypto python2Packages.area
@GrahamcOfBorg build python3Packages.h3 python3Packages.timezonefinder python3Packages.snowflake-sqlalchemy python3Packages.snowflake-connector-python python3Packages.oscrypto python3Packages.area

jonringer
jonringer approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM (although I would prefer some more tests)
commits LGTM

[27 built, 136 copied (719.3 MiB), 119.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76954
18 package were built:
h3 python27Packages.area python27Packages.h3 python27Packages.oscrypto python27Packages.snowflake-connector-python python27Packages.snowflake-sqlalchemy python37Packages.area python37Packages.h3 python37Packages.oscrypto python37Packages.snowflake-connector-python python37Packages.snowflake-sqlalchemy python37Packages.timezonefinder python38Packages.area python38Packages.h3 python38Packages.oscrypto python38Packages.snowflake-connector-python python38Packages.snowflake-sqlalchemy python38Packages.timezonefinder

@jonringer jonringer merged commit 0e4457c into NixOS:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalbasit @jonringer @LnL7