Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/pam: cleanup services #76885

Merged
merged 3 commits into from Jan 9, 2020
Merged

nixos/pam: cleanup services #76885

merged 3 commits into from Jan 9, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 3, 2020

Motivation for this change

Every unneeded pam service will create a file/build process.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

The cups module itself already defines this.
vsftpd is the only ftp server module and defines its own pam service.
i3lock = {};
i3lock-color = {};
screen = {};
vlock = {};
xlock = {};
xscreensaver = {};
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining ones would need custom modules -> That's why I leave them out for this pr.

@Mic92 Mic92 merged commit ff5ddd0 into NixOS:master Jan 9, 2020
@Mic92 Mic92 deleted the pam-cleanup branch January 9, 2020 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants