CI: check for bench breakages #321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's odd, I can't actually find the job I added. Do you have any idea why, @whitequark? |
|
It should be in the build matrix too. |
|
D'oh, right. Thanks, @whitequark. Should be good to go, now. |
|
@m-labs-homu r+ |
|
📌 Commit ff45a37 has been approved by |
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems I am not the only one who accidentally adds a new feature or updates a struct and breaks the bench code. That means the CI should check it.
It is currently allowed to fail, because there are pre-existing issues in master, one of which I plan to fix, another of which I have not looked into.