Skip to content

Feature/gpup #76917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Feature/gpup #76917

wants to merge 2 commits into from
+17 −0

Conversation

ryanpeach
Copy link

Motivation for this change

It's my first nixpkg, and I need some help with it :)

Just want to install gpup from the given repo.

Things done

None of these yet, I'm trying to use nix-build and nix-env to try to install it on my pc.

When I run nix-env -f . -qaP gpup I don't see my package (from the root of my local nixpkgs).

When I run nix-build gpup from pkgs/development/tools' I get can not auto call a function that has an argument without a default vavlue ('stdenv')`

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 4, 2020
stigtsp
stigtsp reviewed Jan 6, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add to pkgs/top-level/all-packages.nix
  • Please squash commits so there is only one commit in the PR
  • Change PR title/commit message to gpup: init at 1.6.1

pkgs/development/tools/gpup/default.nix
repo = "gpup";
sha256 = "0nw9z96x1vk0gm09cz1yy2f870hyn4djb02qhn1f24m58s8mshqj";
};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta section is missing

pkgs/development/tools/gpup/default.nix
buildGoPackage rec {
pname = "gpup";
version = "1.6.1";
rev = "95727c319393a0c7d2add7cc0f454f158989a966";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to src.rev

@stale
Copy link

stale bot commented Jul 4, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2020
@SuperSandro2000
Copy link
Member

Closing because @ryanpeach did not address the reviewer feedback in 10 months.

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ryanpeach @SuperSandro2000 @stigtsp @Janik-Haag