Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.xmodem: init at 0.4.5 #76924

Merged
merged 2 commits into from Jan 7, 2020
Merged

pythonPackages.xmodem: init at 0.4.5 #76924

merged 2 commits into from Jan 7, 2020

Conversation

Emantor
Copy link
Member

@Emantor Emantor commented Jan 4, 2020 •
edited

Motivation for this change

Add the python xmodem module for future modules and applications which depend on it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Emantor Emantor changed the title Pkg/python xmodem pythonPackages.xmodem: init at 0.4.5 Jan 4, 2020
@Emantor Emantor force-pushed the pkg/python-xmodem branch 3 times, most recently from 7dd80ba to 868c493 Compare January 5, 2020 09:22
@Emantor Emantor force-pushed the pkg/python-xmodem branch 2 times, most recently from 1d6b95e to 44a86cb Compare January 6, 2020 05:11
jonringer
jonringer approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/development/python-modules/xmodem/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.xmodem python3Packages.xmodem

@jonringer
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.xmodem python3Packages.xmodem

@markuskowa markuskowa merged commit f8193b1 into NixOS:master Jan 7, 2020
@Emantor Emantor deleted the pkg/python-xmodem branch January 7, 2020 19:28
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 7, 2020
@markuskowa @dtzWill
Merge pull request NixOS#76924 from Emantor/pkg/python-xmodem
5bd81c3 
pythonPackages.xmodem: init at 0.4.5

(cherry picked from commit f8193b1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Emantor @jonringer @markuskowa @Janik-Haag