Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim-plugins: direnv-vim: hardcode the default path to direnv #76926

Merged
merged 1 commit into from
Jan 4, 2020
Merged

vim-plugins: direnv-vim: hardcode the default path to direnv #76926

merged 1 commit into from
Jan 4, 2020
+12 −1

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Jan 4, 2020

Motivation for this change

The plugin direnv-vim requires access to the binary direnv. This PR patches the plugin to hardcode the path to direnv as the default value for g:direnv.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@kalbasit
vim-plugins: direnv-vim: hardcode the default path to direnv

Verified

This commit was signed with the committer’s verified signature. The key has expired.
kalbasit Wael Nasreddine
GPG key ID: FD437548E0BF0F5F
Expired
Verified
Learn about vigilant mode
4eef456
@kalbasit kalbasit requested a review from jonringer as a code owner January 4, 2020 07:41
@ofborg ofborg bot added 6.topic: vim 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 4, 2020
@kalbasit
Copy link
Member Author

kalbasit commented Jan 4, 2020

I tested this locally with kalbasit/shabka@000f0fc. Merging...

@kalbasit kalbasit merged commit 2f22e67 into NixOS:master Jan 4, 2020
@kalbasit kalbasit deleted the nixpkgs_vim-direnv-bin-direnv branch January 4, 2020 19:27
kalbasit added a commit to kalbasit/nixpkgs that referenced this pull request Jan 4, 2020
@kalbasit
vim-plugins: direnv-vim: hardcode the default path to direnv (NixOS#7…

Verified

This commit was signed with the committer’s verified signature. The key has expired.
kalbasit Wael Nasreddine
GPG key ID: FD437548E0BF0F5F
Expired
Verified
Learn about vigilant mode
5c87a63 
…6926)

(cherry picked from commit 2f22e67)
@kalbasit kalbasit mentioned this pull request Jan 4, 2020
Merged
10 tasks
kalbasit added a commit that referenced this pull request Jan 4, 2020
@kalbasit
vim-plugins: direnv-vim: hardcode the default path to direnv (#76926) (…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a307068 
…#76951)

(cherry picked from commit 2f22e67)
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 10, 2020
@kalbasit @dtzWill
vim-plugins: direnv-vim: hardcode the default path to direnv (NixOS#7…

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dtzWill Will Dietz
GPG key ID: EBB0EA4124809D02
Expired
Verified
Learn about vigilant mode
0195f83 
…6926)

(cherry picked from commit 2f22e67)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kalbasit