nixos/tsocks: Add types to the options #76939
Merged
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
In response to #76184.
Things done
Type-infer the options, trying to be most reasonable.
enable
is treated as a boolean in the code.server
has to be a string and it doesn't make sense to merge multiple values.config
is text. Oddly enough the existing code causes a merge with any user-selected value under the deprecatedtypes.string
rules. I decidedtypes.lines
was a safe enough replacement since blank lines aren't significant in the tsocks.conf format.sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
inapplicable./result/bin/
) inapplicablenix path-info -S
before and after) inapplicableNotify maintainers
unclear: Module is deprecated and abandonned.