Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hal-hardware-analyzer: init at 2.0.0 #76960

Merged
merged 1 commit into from Jul 21, 2020
Merged

hal-hardware-analyzer: init at 2.0.0 #76960

merged 1 commit into from Jul 21, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jan 5, 2020 •
edited

Motivation for this change

Neat tool: https://media.ccc.de/v/36c3-10879-hal_-_the_open-source_hardware_analyzer

Works on darwin once #76958 is merged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@typetetris
Copy link
Contributor

Result of nixpkgs-review pr 76960 1

1 package failed to build:
- hal-hardware-analyzer

@typetetris
Copy link
Contributor 

builder for '/nix/store/75i11wafs8kmbkr5impv8p58xdzfhf4a-hal-hardware-analyzer-2.0.0.drv' failed with exit code 1; last 10 log lines:

  -- Generating done
  CMake Warning:
    Manually-specified variables were not used by the project:

      BUILD_TESTING
      CMAKE_EXPORT_NO_PACKAGE_REGISTRY


  CMake Generate step failed.  Build files cannot be regenerated correctly.
cannot build derivation '/nix/store/4fijvh0syl5222x9mabfxp9v14mdhb7m-env.drv': 1 dependencies couldn't be built

@risicle
Copy link
Contributor Author

risicle commented Jul 19, 2020

Fixed now?

@GrahamcOfBorg build hal-hardware-analyzer

typetetris
typetetris reviewed Jul 20, 2020
View reviewed changes
Copy link
Contributor

@typetetris typetetris left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on linux x86_64
  • executables tested on linux x86_64
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • phases are respected
Possible improvements

hal -g aborted in my system with

[20.07.2020 07:31:47] [core] [info] loading plugin '/nix/store/binw7skvbfw8qa8spyv0dlyvff3rbgjw-hal-hardware-analyzer-2.0.0/lib//libhal_gui.so'...
QSocketNotifier: Can only be used with threads started with QThread
[20.07.2020 07:31:47] [core] [info] Starting hal_gui.
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Aborted (core dumped)

Somebody running master should probably test this.

Comments

@risicle
Copy link
Contributor Author

risicle commented Jul 20, 2020

This is normal for qt applications on non-nixos because of qt's attempts at locating plugins - it needs a slight workaround I was going to say this but realized that I'm behind the times and someone's fixed this situation with wrapQtAppsHook, so I added that and it works out of the box now.

@risicle
Copy link
Contributor Author

risicle commented Jul 20, 2020

@GrahamcOfBorg build hal-hardware-analyzer

@risicle
Copy link
Contributor Author

risicle commented Jul 20, 2020

Though macos support seems to have evaporated due to igraph no longer building there :(

typetetris
typetetris approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@typetetris typetetris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hal -g now worked out of the box for me.

@typetetris
Copy link
Contributor

Result of nixpkgs-review pr 76960 1

1 package built:
- hal-hardware-analyzer

@risicle risicle merged commit fd5c0b9 into NixOS:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typetetris typetetris typetetris approved these changes

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @typetetris @doronbehar