Skip to content

pythonPackages.colormath: init at 3.0.0 #76962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2020
Merged

pythonPackages.colormath: init at 3.0.0 #76962

merged 1 commit into from
Jan 9, 2020
+34 −0

Conversation

JonathanReeve
Copy link
Contributor

Motivation for this change

Add a new python package: colormath

Things done

Just added the new package.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

jonringer
jonringer reviewed Jan 5, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, please squash the commits, there should only be one.

pythonPackages.colormath: init at 3.0.0

you could do:

git reset HEAD~5 # put last five commits into unstaged area
git add pkgs/
git commit -m "pythonPackages.colormath: init at 3.0.0"
git push <fork> <branch> --force

I would also like for you to add yourself as a maintainer :) #76640 is a good example of commit structure :). If you do, the commit history should be:

maintainers: add jonathanreeve
pythonPackages.colormath: init at 3.0.0

@ofborg ofborg bot added 6.topic: emacs Text editor 6.topic: erlang 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) labels Jan 5, 2020
@ofborg ofborg bot removed 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: documentation This PR adds or changes documentation 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 5, 2020
@JonathanReeve
Copy link
Contributor Author

Ok I think I got it all into one commit now, and added myself as a maintainer.

@jonringer
Copy link
Contributor

jonringer commented Jan 6, 2020 •
edited
Loading

I would also like for you to add yourself as a maintainer :) #76640 is a good example of commit structure :). If you do, the commit history should be:

maintainers: add jonathanreeve
pythonPackages.colormath: init at 3.0.0

attribute 'JonathanReeve' missing, at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-1-lassulus.ewr1.nix.ci/pkgs/development/python-modules/colormath/default.nix:27:21

there should be 2 commits, one adding you as a maintainer in maintainers.nix, and the other adding the package

ryantm
ryantm previously requested changes Jan 6, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix ofborg evaluation errors please

@JonathanReeve
Copy link
Contributor Author

Oops, it's case sensitive. It should be fixed now. I'm already in the maintainer's list, so that will explain the single commit here.

@jonringer
Copy link
Contributor

ah, I assumed since you left it out initially that you weren't added. I apologize

@JonathanReeve JonathanReeve requested review from ryantm and jonringer and removed request for alyssais and FRidh January 6, 2020 22:37
jonringer
jonringer reviewed Jan 6, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small nitpicks, otherwise LGTM

@infinisil infinisil changed the title Add a new Python package Add python package colormath Jan 6, 2020
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Jan 7, 2020
@JonathanReeve
Copy link
Contributor Author

Cool, I've just made those changes, squashed all the commits, and force-pushed the result.

@jonringer jonringer changed the title Add python package colormath pythonPackages.colormath: init at 3.0.0 Jan 9, 2020
@jonringer jonringer dismissed ryantm’s stale review January 9, 2020 23:53

eval works just fine now

jonringer
jonringer approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
has tests 👍

[4 built, 6 copied (42.3 MiB), 6.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76962
3 package were built:
python27Packages.colormath python37Packages.colormath python38Packages.colormath

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.colormath python37Packages.colormath python38Packages.colormath

@jonringer jonringer merged commit e413474 into NixOS:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@basvandijk basvandijk

@cdepillabout cdepillabout

@edwtjo edwtjo

@Ericson2314 Ericson2314

@etu etu

@LnL7 LnL7

@matthewbauer matthewbauer

@Mic92 Mic92

@peti peti

@rycee rycee

@thoughtpolice thoughtpolice

@ttuegel ttuegel

@zimbatm zimbatm

@ryantm ryantm

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JonathanReeve @jonringer @ryantm