Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vym: 2.6.11. -> 2.7.0 and fix qt5 #73543

Closed
wants to merge 1 commit into from
Closed

vym: 2.6.11. -> 2.7.0 and fix qt5 #73543

wants to merge 1 commit into from

Conversation

nek0
Copy link
Contributor

@nek0 nek0 commented Nov 17, 2019

Motivation for this change

New major version of vym was released and the application was affected by the qt5 xcb plugin error.

Things done

Version update and addition of wrapQtAppsHook.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @AndersonTorres

@ofborg ofborg bot requested a review from AndersonTorres November 17, 2019 09:30
@dtzWill
Copy link
Member

dtzWill commented Nov 17, 2019

Closing in favor of existing PR with these changes (and 2.7.1). Thanks for submitting, though! Does that PR address the issue you mention?

#73483

@dtzWill dtzWill closed this Nov 17, 2019
@nek0
Copy link
Contributor Author

nek0 commented Nov 17, 2019

The mentioned pull Request does not incorporate the wrapQtAppsHook, so the executable probably won't run properly. Also I would like to mention, that version 2.7.1 is a development snapshot of vym.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nek0 @dtzWill