Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geoipupdate: Init at 4.1.5 #73578

Merged
merged 1 commit into from Nov 19, 2019
Merged

geoipupdate: Init at 4.1.5 #73578

merged 1 commit into from Nov 19, 2019

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Nov 17, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@dasJ
Copy link
Member Author

dasJ commented Nov 17, 2019

See also #55867

prusnak
prusnak requested changes Nov 17, 2019
View reviewed changes
pkgs/applications/misc/geoipupdate/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/geoipupdate/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/geoipupdate/default.nix Outdated Show resolved Hide resolved
@dasJ dasJ force-pushed the geoip-init branch 2 times, most recently from f057b43 to 2e9010c Compare November 17, 2019 19:06
@dasJ
Copy link
Member Author

dasJ commented Nov 17, 2019

@prusnak Done

prusnak
prusnak requested changes Nov 17, 2019
View reviewed changes
pkgs/applications/misc/geoipupdate/default.nix

meta = with stdenv.lib; {
description = "Automatic GeoIP database updater";
license = with licenses; [ asl20 ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one more :-/

homepage = "https://github.com/maxmind/geoipupdate";

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that but I wasn't sure if this is really the homepage :/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just some way to link to the correct repo, as there may be other repos with the same name. github is commonly used as a landing page

@dasJ
Copy link
Member Author

dasJ commented Nov 17, 2019

Hash mismatches were due to me using the wrong callPackage while testing…

@ofborg ofborg bot requested a review from kalbasit November 17, 2019 19:12
@dasJ
Copy link
Member Author

dasJ commented Nov 17, 2019

@GrahamcOfBorg build geoipupdate

@dasJ
Copy link
Member Author

dasJ commented Nov 17, 2019

@jonringer Done

@dasJ dasJ mentioned this pull request Nov 17, 2019
Merged
10 tasks
@dasJ
Copy link
Member Author

dasJ commented Nov 18, 2019

@veprbl Done

jonringer
jonringer approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please apply @prusnak suggestion :)

@dasJ
Copy link
Member Author

dasJ commented Nov 19, 2019

@prusnak @jonringer Done

jonringer
jonringer approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM
repo looks active enough

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73578
1 package were build:
geoipupdate

@jonringer
Copy link
Contributor

@GrahamcOfBorg build geoipupdate

@jonringer jonringer merged commit f06ca05 into NixOS:master Nov 19, 2019
@dasJ dasJ deleted the geoip-init branch November 19, 2019 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@prusnak prusnak prusnak requested changes

@jonringer jonringer jonringer approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dasJ @jonringer @prusnak @veprbl