Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r19.03] dpdk: 17.11.2 -> 17.11.9, addressing CVE-2019-14818 #73580

Merged
merged 1 commit into from Dec 18, 2019
Merged

[r19.03] dpdk: 17.11.2 -> 17.11.9, addressing CVE-2019-14818 #73580

merged 1 commit into from Dec 18, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Nov 17, 2019

Motivation for this change

Backport of #73555

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from domenkozar November 17, 2019 19:52
nh2
nh2 approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but what about 19.09?

That still has the vulnerable version:

nixpkgs/pkgs/os-specific/linux/dpdk/default.nix

Line 11 in cfc23a2

version = "17.11.2";

@risicle
Copy link
Contributor Author

risicle commented Dec 16, 2019

Good question. Don't know why I didn't do these in the other order...

@risicle
Copy link
Contributor Author

risicle commented Dec 17, 2019 •
edited

See #75829 for 19.09

@nh2 nh2 merged commit d1dff0b into NixOS:release-19.03 Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 approved these changes

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @nh2 @veprbl