Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rasm: init at 0.117 #73518

Merged
merged 1 commit into from Dec 16, 2019
Merged

rasm: init at 0.117 #73518

merged 1 commit into from Dec 16, 2019

Conversation

bignaux
Copy link
Contributor

@bignaux bignaux commented Nov 16, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jonringer
jonringer reviewed Nov 17, 2019
View reviewed changes
pkgs/development/compilers/rasm/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/rasm/default.nix Outdated

src = fetchurl {
name = "rasm_v0116_src.zip";
url = "http://www.cpcwiki.eu/forum/programming/rasm-z80-assembler-in-beta/?action=dlattach;attach=30015";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a more official url, other than some download links on a forum? Would be nice if he/she had a github/gitlab, especially seeing as it's mit license anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the official url according http://www.roudoudou.com/rasm/ . If i've time i would contact author but you know, most of time, such people doesn't work with git and has no opensource culture. BTW I'll try later since it's a compatriot.

pkgs/development/compilers/rasm/default.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/rasm/default.nix Outdated Show resolved Hide resolved
@bignaux
Copy link
Contributor Author

bignaux commented Dec 14, 2019

I'd contacted the author, btw he changed src file without let old or change url so this could not work.

@bignaux
Copy link
Contributor Author

bignaux commented Dec 16, 2019

src.url fixed with the help of the author.

@bignaux bignaux changed the title rasm: init at 0.116 rasm: init at 0.117 Dec 16, 2019
jonringer
jonringer approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM

[3 built, 53 copied (233.6 MiB), 55.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73518
1 package were built:
rasm

@jonringer
Copy link
Contributor

@GrahamcOfBorg build rasm

@jonringer jonringer merged commit 3ad650a into NixOS:master Dec 16, 2019
@bignaux bignaux deleted the rasm branch December 17, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bignaux @jonringer