Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mlpack: init at 3.2.1 #73469

Closed
wants to merge 1 commit into from
Closed

mlpack: init at 3.2.1 #73469

wants to merge 1 commit into from

Conversation

AmineChikhaoui
Copy link
Member

@AmineChikhaoui AmineChikhaoui commented Nov 15, 2019 •
edited

  • ensmallen: init at 2.10.3
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@AmineChikhaoui
Copy link
Member Author

@GrahamcOfBorg build mlpack mlpackOpenMP ensmallen ensmallenOpenMP

JohnAZoidberg
JohnAZoidberg requested changes Nov 16, 2019
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put some empty lines between groups of attributes, like after version.
That makes it look less bunched up and is common in nixpkgs :)

How did you generate the hashes? I haven't seen that format(base64?) before in nixpkgs.

pkgs/development/libraries/ensmallen/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/ensmallen/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/mlpack/default.nix Outdated Show resolved Hide resolved
@AmineChikhaoui
Copy link
Member Author

Please put some empty lines between groups of attributes, like after version.
That makes it look less bunched up and is common in nixpkgs :)

Done

How did you generate the hashes? I haven't seen that format(base64?) before in nixpkgs.

It was added a while back in Nix (NixOS/nix@6024dc1), so when you use a recent version it would suggest those SRI hashes :)

JohnAZoidberg
JohnAZoidberg requested changes Nov 17, 2019
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't see some things the first time around.

pkgs/development/libraries/ensmallen/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/ensmallen/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/mlpack/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/mlpack/default.nix Show resolved Hide resolved
pkgs/development/libraries/mlpack/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/mlpack/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/ensmallen/default.nix Show resolved Hide resolved
@AmineChikhaoui
mlpack: init at 3.2.1
101d0b8 
* ensmallen: init at 2.10.3
@AmineChikhaoui
Copy link
Member Author

I guess the Ofborg failure is likely the builder running out of memory ? maybe because of enableParallelBuilding being set to true.

@AmineChikhaoui AmineChikhaoui deleted the mlpack branch December 25, 2019 10:14
@eadwu eadwu mentioned this pull request Mar 1, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AmineChikhaoui @JohnAZoidberg