Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit: 1.12.0 -> 1.13.0 #73491

Merged
merged 3 commits into from Dec 5, 2019
Merged

unit: 1.12.0 -> 1.13.0 #73491

merged 3 commits into from Dec 5, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Nov 16, 2019 •
edited

Motivation for this change

Update nginx unit to version 1.13.0

Changelog:

  • Feature: basic support for HTTP reverse proxying.
  • Feature: compatibility with Python 3.8.
  • Bugfix: memory leak in Python application processes when the close handler was used.
  • Bugfix: threads in Python applications might not work correctly.
  • Bugfix: Ruby on Rails applications might not work on Ruby 2.6.
  • Bugfix: backtraces for uncaught exceptions in Python 3 might be logged with significant delays.
  • Bugfix: explicit setting a namespaces isolation option to false might have enabled it.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 17, 2019

Added commit to fix this error:
nginx/unit#349
#73513

@ofborg ofborg bot added the 6.topic: ruby label Nov 17, 2019
@ofborg ofborg bot requested review from manveru and vrthra November 17, 2019 08:56
@alyssais
Copy link
Member

alyssais commented Nov 17, 2019 via email

@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 17, 2019

https://www.speedshop.co/2018/03/28/nginx-unit-for-ruby.html - ruby application server.

For example, if need to run applications, one of which supports version 2.4, and the other application only 2.6

ryantm
ryantm requested changes Nov 17, 2019
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this involves hundreds of rebuilds it should probably target the staging branch.

@Izorkin Izorkin changed the base branch from master to staging November 18, 2019 06:40
@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 18, 2019

Rebased to staging.

@ofborg ofborg bot added 6.topic: emacs 6.topic: GNOME GNOME desktop environment and its underlying platform labels Nov 18, 2019
@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 18, 2019

@GrahamcOfBorg eval

@FRidh FRidh added this to Ready in Staging Nov 19, 2019
FRidh
FRidh requested changes Nov 24, 2019
View reviewed changes
pkgs/servers/http/unit/default.nix Outdated Show resolved Hide resolved
@FRidh FRidh self-requested a review December 5, 2019 09:25
@FRidh FRidh merged commit 353ec3f into NixOS:staging Dec 5, 2019
Staging automation moved this from Ready to Done Dec 5, 2019
@Izorkin Izorkin deleted the unit branch December 7, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@ryantm ryantm ryantm approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@zimbatm zimbatm Awaiting requested review from zimbatm

@manveru manveru Awaiting requested review from manveru

@vrthra vrthra Awaiting requested review from vrthra

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

@ttuegel ttuegel Awaiting requested review from ttuegel

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 11.by: package-maintainer
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Izorkin @alyssais @ryantm @FRidh @jonringer