Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pynvim: 0.3.2 -> 0.4.0 #73488

Merged
merged 1 commit into from Nov 17, 2019
Merged

pynvim: 0.3.2 -> 0.4.0 #73488

merged 1 commit into from Nov 17, 2019

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Nov 16, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@lovesegfault
Copy link
Member

Works over here :)

jonringer
jonringer approved these changes Nov 17, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM

[15 built, 46 copied (203.9 MiB), 41.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73488
7 package were build:
gnvim neovim-qt neovim-remote python27Packages.pynvim python37Packages.pynvim python38Packages.pynvim vimPlugins.sved

@jonringer
Copy link
Contributor

@GrahamcOfBorg build gnvim neovim-qt neovim-remote python27Packages.pynvim python37Packages.pynvim python38Packages.pynvim vimPlugins.sved

@jonringer
Copy link
Contributor

darwin failures seem to be related to other packages

@jonringer jonringer merged commit 430b7b2 into NixOS:master Nov 17, 2019
@doronbehar doronbehar deleted the update-pynvim branch March 2, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @lovesegfault @jonringer