riot-desktop: fix missing tray icon #73054
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
The PR message has valuable info I'd like to see in the commit message. |
The tray icon has always been missing for me (on sway / waybar). It turns out that it is looked up in a different location than where we package it. Overall, it seems we are not at all following the upstream layout as can be seen in data.tar.xz available at packages.riot.im/debian/pool/main/r/riot-web/riot-web_1.4.2_amd64.deb This is a small fix that works for me. May not be optimal :-).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tray icon has always been missing for me (on sway / waybar).
It turns out that it is looked up in a different location than where we
package it.
Overall, it seems we are not at all following the upstream layout as can
be seen in data.tar.xz available at https://packages.riot.im/debian/pool/main/r/riot-web/riot-web_1.4.2_amd64.deb
This is a small fix that works for me. May not be optimal :-).
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @pacien @worldofpeace