Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zim: fix missing app name and icon on Wayland #73528

Closed
wants to merge 1 commit into from
Closed

zim: fix missing app name and icon on Wayland #73528

wants to merge 1 commit into from
+3 −0

Conversation

lightbulbjim
Copy link
Contributor

Motivation for this change

Since zim is wrapped the appid changes to .zim-wrapped. Renaming the
desktop file to match means that the app icon is displayed properly on
Wayland.

Tested on Gnome/Wayland.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @pSub

Sorry, something went wrong.

@lightbulbjim
zim: fix missing app name and icon on Wayland

Unverified

No user is associated with the committer email.
Learn about vigilant mode
0b895dd 
Since zim is wrapped the appid changes to `.zim-wrapped`. Renaming the
desktop file to match means that the app icon is displayed properly on
Wayland.

Tested on Gnome/Wayland.
@ofborg ofborg bot requested a review from pSub November 17, 2019 01:43
@matthewbauer
Copy link
Member

This seems kind of awkward. Ideally we could figure out how to set the appid to zim via wrapper configs.

@lightbulbjim
Copy link
Contributor Author

I agree that it's awkward. Other package where this has been a problem generally use QT, which provides a function to set the app ID. It looks like the GTK equivalent might be this.

Let me tinker with it.

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@jtojnar
Copy link
Member

jtojnar commented Jun 1, 2020

The preFixup looks suspicious. Is it still problem when manual --argv0 override is removed? IIRC GTK 3 sets the desktop id from the program name and makeWrapper sets unwrapped argv0 by default.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@SuperSandro2000 SuperSandro2000 marked this pull request as draft November 28, 2020 04:30
@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@ghost ghost closed this Dec 20, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lightbulbjim @matthewbauer @jtojnar @wegank