New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tensorman: init at 0.1.0 #73452
tensorman: init at 0.1.0 #73452
Conversation
#{ pkgconfig, stdenv, rustPlatform, rustc, cargo, docker, openssl, fetchzip }: | ||
|
||
rustPlatform.buildRustPackage rec { | ||
name = "tensorman-${version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use pname
.
name = "tensorman-${version}"; | ||
version = "0.1.0"; | ||
|
||
src = fetchzip{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use fetchFromGitHub
with specific revision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not possible as they do not track their releases on github yet
version = "0.1.0"; | ||
|
||
src = fetchzip{ | ||
url = "https://github.com/pop-os/tensorman/archive/master_eoan.zip"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to fail after the first commit to master.
homepage = https://github.com/pop-os/tensorman/; | ||
license = stdenv.lib.licenses.gpl3; | ||
platforms = [ "x86_64-linux" ]; | ||
maintainers = [ ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind to maintain this package? We would like to avoid adding new packages without maintainers.
description = "Utility for easy management of Tensorflow containers"; | ||
homepage = https://github.com/pop-os/tensorman/; | ||
license = stdenv.lib.licenses.gpl3; | ||
platforms = [ "x86_64-linux" ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we try to build this on darwin maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it depends on docker and the developers state that it is written for Linux also I have no way of testing this on darwin
would be very nice If you could rebase your commit history and force push this branch, so we have 2 commits in the end, one for the maintainers addition and one for the package |
Co-Authored-By: Lassulus <github@lassul.us>
Motivation for this change
Easy management of Tensorflow containers with Docker as the backend.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @