Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lnd: 0.7.1 -> 0.8.1 #73567

Merged
merged 1 commit into from Nov 17, 2019
Merged

lnd: 0.7.1 -> 0.8.1 #73567

merged 1 commit into from Nov 17, 2019

Conversation

jonasnick
Copy link
Contributor

Motivation for this change

changelog: https://github.com/lightningnetwork/lnd/releases

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (ArchLinux)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Cypherpunk2140

@ofborg ofborg bot requested a review from kalbasit November 17, 2019 15:44
prusnak
prusnak approved these changes Nov 17, 2019
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

lnd --version shows lnd version 0.8.0-beta commit= but I expect this is a problem with the upstream.

ryantm
ryantm approved these changes Nov 17, 2019
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no non-beta release of this package, so having a beta release is okay.

@ryantm ryantm merged commit 35f3eca into NixOS:master Nov 17, 2019
@ryantm
Copy link
Member

ryantm commented Nov 17, 2019

I made an upstream issue for the version lightningnetwork/lnd#3735

@ryantm
Copy link
Member

ryantm commented Nov 19, 2019

@jonasnick He says the problem is on our end because we are not using the Makefile to build it. Could you look into fixing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

@prusnak prusnak prusnak approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonasnick @ryantm @prusnak