Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.rxe: port to python #73568

Merged
merged 2 commits into from Nov 20, 2019
Merged

nixosTests.rxe: port to python #73568

merged 2 commits into from Nov 20, 2019

Conversation

markuskowa
Copy link
Member

Motivation for this change

Port RXE test to python test framework #72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@markuskowa
Copy link
Member Author

markuskowa commented Nov 17, 2019 •
edited

@GrahamcOfBorg test rxe

@tfc tfc mentioned this pull request Nov 17, 2019
Closed
tfc
tfc reviewed Nov 20, 2019
View reviewed changes
nixos/tests/rxe.nix Outdated Show resolved Hide resolved
@markuskowa markuskowa merged commit 196880d into NixOS:master Nov 20, 2019
@markuskowa markuskowa deleted the prt-rxe-test branch November 20, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfc tfc tfc approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markuskowa @tfc