Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http-prompt: fix build #73482

Merged
merged 1 commit into from
Nov 16, 2019
Merged

http-prompt: fix build #73482

merged 1 commit into from
Nov 16, 2019
+4 −5

Conversation

ryneeverett
Copy link
Contributor

I don't really understand why this works:

  • Building with python3 because python2 fails with "error: invalid command
    'bdist_wheel'".
  • Specifying the path to prompt_toolkit v1 because otherwise the dependency
    resolution fails with "ERROR: Could not find a version that satisfies the
    requirement prompt-toolkit<2.0.0,>=1.0.0 (from http-prompt==1.0.0) (from
    versions: none) ERROR: No matching distribution found for
    prompt-toolkit<2.0.0,>=1.0.0 (from http-prompt==1.0.0)".
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthiasbeyer

Sorry, something went wrong.

@ryneeverett
http-prompt: fix build
0e283d6 
I don't really understand why this works:

- Building with python3 because python2 fails with "error: invalid command
'bdist_wheel'".
- Specifying the path to prompt_toolkit v1 because otherwise the dependency
resolution fails with "ERROR: Could not find a version that satisfies the
requirement prompt-toolkit<2.0.0,>=1.0.0 (from http-prompt==1.0.0) (from
versions: none) ERROR: No matching distribution found for
prompt-toolkit<2.0.0,>=1.0.0 (from http-prompt==1.0.0)".
@Mic92 Mic92 merged commit c19b3dc into NixOS:master Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryneeverett @Mic92