Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-values] min() and max() tests don't follow the spec unit ordering #20287

Closed
smfr opened this issue Nov 16, 2019 · 3 comments
Closed

[css-values] min() and max() tests don't follow the spec unit ordering #20287

smfr opened this issue Nov 16, 2019 · 3 comments

Comments

@smfr
Copy link
Contributor

smfr commented Nov 16, 2019

css/css-values/minmax-length-percent-serialize.html has, for example:

test_valid_length_percent('min(1px + 1%)', 'min(1px + 1%)');

https://drafts.csswg.org/css-values-4/#sort-a-calculations-children says that units are sorted with % before lengths, so the output should be min(1% + 1px)

@smfr
Copy link
Contributor Author

smfr commented Nov 16, 2019

@xiaochengh

chromium-wpt-export-bot pushed a commit that referenced this issue Nov 18, 2019
…e.html

The wpt makes incorrect assertions on the serialization of summations,
which is corrected as per:

Spec: https://drafts.csswg.org/css-values-4/#sort-a-calculations-children
WPT issue: #20287

Bug: 904805
Change-Id: I5775ed09d05484d5bd6a040a6635bee93ba4b4e0
aarongable pushed a commit to chromium/chromium that referenced this issue Nov 19, 2019
…e.html

The wpt makes incorrect assertions on the serialization of summations,
which is corrected as per:

Spec: https://drafts.csswg.org/css-values-4/#sort-a-calculations-children
WPT issue: web-platform-tests/wpt#20287

Bug: 904805
Change-Id: I5775ed09d05484d5bd6a040a6635bee93ba4b4e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922331
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716720}
chromium-wpt-export-bot pushed a commit that referenced this issue Nov 19, 2019
…e.html

The wpt makes incorrect assertions on the serialization of summations,
which is corrected as per:

Spec: https://drafts.csswg.org/css-values-4/#sort-a-calculations-children
WPT issue: #20287

Bug: 904805
Change-Id: I5775ed09d05484d5bd6a040a6635bee93ba4b4e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922331
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716720}
chromium-wpt-export-bot pushed a commit that referenced this issue Nov 19, 2019
…e.html

The wpt makes incorrect assertions on the serialization of summations,
which is corrected as per:

Spec: https://drafts.csswg.org/css-values-4/#sort-a-calculations-children
WPT issue: #20287

Bug: 904805
Change-Id: I5775ed09d05484d5bd6a040a6635bee93ba4b4e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922331
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716720}
@xiaochengh
Copy link
Contributor

The test expectation has been fixed. We can close the issue now.

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 29, 2019
…inmax-length-percent-serialize.html, a=testonly

Automatic update from web-platform-tests
Correct expectations of css/css-values/minmax-length-percent-serialize.html

The wpt makes incorrect assertions on the serialization of summations,
which is corrected as per:

Spec: https://drafts.csswg.org/css-values-4/#sort-a-calculations-children
WPT issue: web-platform-tests/wpt#20287

Bug: 904805
Change-Id: I5775ed09d05484d5bd6a040a6635bee93ba4b4e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922331
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716720}

--

wpt-commits: cfcdb31e6f20d37e9e6a7642d42aa44e2ff22c7c
wpt-pr: 20305
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Nov 29, 2019
…inmax-length-percent-serialize.html, a=testonly

Automatic update from web-platform-tests
Correct expectations of css/css-values/minmax-length-percent-serialize.html

The wpt makes incorrect assertions on the serialization of summations,
which is corrected as per:

Spec: https://drafts.csswg.org/css-values-4/#sort-a-calculations-children
WPT issue: web-platform-tests/wpt#20287

Bug: 904805
Change-Id: I5775ed09d05484d5bd6a040a6635bee93ba4b4e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922331
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716720}

--

wpt-commits: cfcdb31e6f20d37e9e6a7642d42aa44e2ff22c7c
wpt-pr: 20305
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Nov 30, 2019
…inmax-length-percent-serialize.html, a=testonly

Automatic update from web-platform-tests
Correct expectations of css/css-values/minmax-length-percent-serialize.html

The wpt makes incorrect assertions on the serialization of summations,
which is corrected as per:

Spec: https://drafts.csswg.org/css-values-4/#sort-a-calculations-children
WPT issue: web-platform-tests/wpt#20287

Bug: 904805
Change-Id: I5775ed09d05484d5bd6a040a6635bee93ba4b4e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922331
Reviewed-by: Rune Lillesveen <futharkchromium.org>
Commit-Queue: Xiaocheng Hu <xiaochenghchromium.org>
Cr-Commit-Position: refs/heads/master{#716720}

--

wpt-commits: cfcdb31e6f20d37e9e6a7642d42aa44e2ff22c7c
wpt-pr: 20305

UltraBlame original commit: bdced0a956c4e950c2889c4b1e0c30466b03f660
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Nov 30, 2019
…inmax-length-percent-serialize.html, a=testonly

Automatic update from web-platform-tests
Correct expectations of css/css-values/minmax-length-percent-serialize.html

The wpt makes incorrect assertions on the serialization of summations,
which is corrected as per:

Spec: https://drafts.csswg.org/css-values-4/#sort-a-calculations-children
WPT issue: web-platform-tests/wpt#20287

Bug: 904805
Change-Id: I5775ed09d05484d5bd6a040a6635bee93ba4b4e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922331
Reviewed-by: Rune Lillesveen <futharkchromium.org>
Commit-Queue: Xiaocheng Hu <xiaochenghchromium.org>
Cr-Commit-Position: refs/heads/master{#716720}

--

wpt-commits: cfcdb31e6f20d37e9e6a7642d42aa44e2ff22c7c
wpt-pr: 20305

UltraBlame original commit: bdced0a956c4e950c2889c4b1e0c30466b03f660
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Nov 30, 2019
…inmax-length-percent-serialize.html, a=testonly

Automatic update from web-platform-tests
Correct expectations of css/css-values/minmax-length-percent-serialize.html

The wpt makes incorrect assertions on the serialization of summations,
which is corrected as per:

Spec: https://drafts.csswg.org/css-values-4/#sort-a-calculations-children
WPT issue: web-platform-tests/wpt#20287

Bug: 904805
Change-Id: I5775ed09d05484d5bd6a040a6635bee93ba4b4e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922331
Reviewed-by: Rune Lillesveen <futharkchromium.org>
Commit-Queue: Xiaocheng Hu <xiaochenghchromium.org>
Cr-Commit-Position: refs/heads/master{#716720}

--

wpt-commits: cfcdb31e6f20d37e9e6a7642d42aa44e2ff22c7c
wpt-pr: 20305

UltraBlame original commit: bdced0a956c4e950c2889c4b1e0c30466b03f660
@stephenmcgruer
Copy link
Contributor

Closing based on #20287 (comment); @smfr please re-open if you think it's still wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants