Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keybase, keybase-gui: 4.7.2 -> 5.0.0; add dependence, license #73480

Merged
merged 3 commits into from Nov 17, 2019
Merged

keybase, keybase-gui: 4.7.2 -> 5.0.0; add dependence, license #73480

merged 3 commits into from Nov 17, 2019

Conversation

judaew
Copy link
Contributor

@judaew judaew commented Nov 16, 2019

Motivation for this change

Update from 4.7.2 to 5.0.0 and add libappindicator-gtk for keybase-gui

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from puffnfresh, ehmry and np November 16, 2019 01:47
@judaew judaew changed the title keybase, keybase-gui: 4.7.2 -> 5.0.0 and add dependence keybase, keybase-gui: 4.7.2 -> 5.0.0; add dependence, license Nov 17, 2019
ryantm
ryantm approved these changes Nov 17, 2019
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review pr passed; both binaries work on NixOS for me

thanks!

@ryantm ryantm merged commit 2c7d994 into NixOS:master Nov 17, 2019
@judaew
Copy link
Contributor Author

judaew commented Nov 17, 2019

You are welcome 🌟!

@judaew
Copy link
Contributor Author

judaew commented Nov 17, 2019

@ryantm Please close this pull request #72147 . The commit has been moved here and the change is already merged.

@ryantm ryantm mentioned this pull request Nov 17, 2019
Closed
10 tasks
@judaew judaew deleted the keybase-update branch November 17, 2019 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

@puffnfresh puffnfresh Awaiting requested review from puffnfresh

@ehmry ehmry Awaiting requested review from ehmry

@np np Awaiting requested review from np

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@judaew @ryantm @mogorman