Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/cabal2nix
base: 39f6c39f2a54
Choose a base ref
...
head repository: NixOS/cabal2nix
compare: 650d5300c6bb
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Nov 15, 2019

  1. Normalize flags to all-lowercase before handing them to Cabal. 

    Cabal expects the payload of the "opaque" FlagName type to be spelled in all
lower-case characters. The mkFlagName function, however, does not ensure that
invariant. We need a good solution to avoid this pitfall. For the time being,
we simply convert all flags used in this module to lower-case ourselves, but
chances are that there are other places in cabal2nix that create improper
FlagName instances through the official API.

Related: NixOS/nixpkgs#73392
    @peti
    peti committed Nov 15, 2019
    Copy the full SHA
    650d530 View commit details
    Browse the repository at this point in the history