Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazygit: 0.8 -> 0.10.6 #73471

Closed
wants to merge 7 commits into from
Closed

lazygit: 0.8 -> 0.10.6 #73471

wants to merge 7 commits into from

Conversation

equirosa
Copy link
Contributor

@equirosa equirosa commented Nov 15, 2019 •
edited

Motivation for this change

Current version of lazygit is slightly outdated.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz

@ofborg ofborg bot requested review from ehmry and fpletz November 15, 2019 21:03
@JohnAZoidberg
Copy link
Member

Also please squash the commits together, make sure everything fits CONTRIBUTING.md and tick that last box.

For next time: It's nice to include a link to the new release and/or changelog in "Motivation" :)

@equirosa
Copy link
Contributor Author

Also please squash the commits together, make sure everything fits CONTRIBUTING.md and tick that last box.

For next time: It's nice to include a link to the new release and/or changelog in "Motivation" :)

Got it! Will fix ASAP :)

@equirosa equirosa closed this Dec 3, 2019
@JohnAZoidberg
Copy link
Member

Why closed? Would you like to update it to 0.11.3.

@equirosa
Copy link
Contributor Author

equirosa commented Dec 3, 2019

Why closed? Would you like to update it to 0.11.3.

It was the first time having to make some changes to a pull request so I thought to make a new one since the version change was different. Kinda new to this...

@JohnAZoidberg
Copy link
Member

Did you make a new one? Please link to it here.
No, you don't have to make a new one. It's perfectly fine, to continue here. Just use make your changes (even rewriting old commits) and git push --force. :)

@equirosa
Copy link
Contributor Author

equirosa commented Dec 4, 2019

Did you make a new one? Please link to it here.
No, you don't have to make a new one. It's perfectly fine, to continue here. Just use make your changes (even rewriting old commits) and git push --force. :)

Oh, ok! Thanks for your help! 😄
And here's the other one I made: #74895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg requested changes

@ehmry ehmry Awaiting requested review from ehmry

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@equirosa @JohnAZoidberg