Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/lorri: add to environment.systemPackages #73462

Merged
merged 1 commit into from Nov 15, 2019
Merged

nixos/lorri: add to environment.systemPackages #73462

merged 1 commit into from Nov 15, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Nov 15, 2019 •
edited

most likely, people enabling the lorri module also want to use it,
without explicitly having to add it to users.users.<username>.packages.

cc @curiousleo @Profpatsch

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@flokli
Copy link
Contributor Author

flokli commented Nov 15, 2019

@GrahamcOfBorg test lorri

@flokli
nixos/lorri: add to environment.systemPackages
fd7d88f 
most likely, people enabling the lorri module also want to use it,
without explicitly having to add it to users.users.<username>.packages.

cc @curiousleo @Profpatsch
@flokli flokli merged commit 01f0b32 into NixOS:master Nov 15, 2019
@flokli flokli deleted the lorri-module-systempackage branch November 15, 2019 16:23
@flokli
Copy link
Contributor Author

flokli commented Nov 15, 2019

backported to 19.09 in 78486a8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Profpatsch approved these changes

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @Profpatsch