Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-tools: teach about nix's include path [19.09] #73546

Merged
merged 1 commit into from Dec 22, 2019
Merged

clang-tools: teach about nix's include path [19.09] #73546

merged 1 commit into from Dec 22, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 17, 2019

By translating NIX_CFLAGS_COMPILE to CPATH,
all tools will now find c headers properly,
when run in a nix-shell.

(cherry picked from commit a10ef1a)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Mic92
clang-tools: teach about nix's include path
649ecdc 
By translating NIX_CFLAGS_COMPILE to CPATH,
all tools will now find c headers properly,
when run in a nix-shell.

(cherry picked from commit a10ef1a)
@Mic92
Copy link
Member Author

Mic92 commented Nov 17, 2019

Backport of #73345

@ofborg ofborg bot requested a review from aherrmann November 17, 2019 10:49
knedlsepp
knedlsepp approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@knedlsepp knedlsepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition to 19.09!

@Mic92 Mic92 merged commit 9bcf114 into NixOS:release-19.09 Dec 22, 2019
@Mic92 Mic92 deleted the clang-tools-backport branch December 22, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knedlsepp knedlsepp knedlsepp approved these changes

@aherrmann aherrmann Awaiting requested review from aherrmann

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @knedlsepp