Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quarte: use qt5’s mkDerivation and an other fix 19.09 backport #73547

Merged
merged 2 commits into from Feb 2, 2020
Merged

quarte: use qt5’s mkDerivation and an other fix 19.09 backport #73547

merged 2 commits into from Feb 2, 2020

Conversation

ahiaao
Copy link
Contributor

@ahiaao ahiaao commented Nov 17, 2019

Motivation for this change

Cherry picked #67544 to fix https://hydra.nixos.org/build/106243976

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vbgl

@ahiaao ahiaao requested a review from FRidh as a code owner November 17, 2019 11:15
@ahiaao ahiaao changed the title Qarte+fix qt platform backport quarte: use qt5’s mkDerivation and an other fix 19.09 backport Nov 17, 2019
@ofborg ofborg bot requested review from svanderburg and vbgl November 17, 2019 11:32
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/112

@worldofpeace
Copy link
Contributor

@ahiaao Please use git cherry-pick -x https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes

@vbgl @ahiaao
qarte: use qt5’s mkDerivation
0907482 
See NixOS#65399

(cherry picked from commit e063d08)
@vbgl @ahiaao
qarte: use pyqt5_with_qtmultimedia
723af8f 
Otherwise, qarte fails at run-time with:

>     from PyQt5.QtMultimedia import QMediaPlayer
> ModuleNotFoundError: No module named 'PyQt5.QtMultimedia'

(cherry picked from commit ef15478)
@ahiaao ahiaao force-pushed the qarte+fix-qt-platform-backport branch from 3e26139 to 723af8f Compare February 2, 2020 01:36
@ahiaao
Copy link
Contributor Author

ahiaao commented Feb 2, 2020

@worldofpeace Resolved

@worldofpeace worldofpeace merged commit 10e175a into NixOS:release-19.09 Feb 2, 2020
@ahiaao ahiaao deleted the qarte+fix-qt-platform-backport branch February 18, 2020 21:44
@ahiaao ahiaao restored the qarte+fix-qt-platform-backport branch February 18, 2020 21:44
@ahiaao ahiaao deleted the qarte+fix-qt-platform-backport branch February 18, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@svanderburg svanderburg Awaiting requested review from svanderburg

@vbgl vbgl Awaiting requested review from vbgl

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahiaao @nixos-discourse @worldofpeace @vbgl