Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pavucontrol, waybar: Use system style #73548

Merged
merged 2 commits into from Jan 14, 2020
Merged

pavucontrol, waybar: Use system style #73548

merged 2 commits into from Jan 14, 2020

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Nov 17, 2019

Motivation for this change

pavucontrol did not respect the system gtk style.
Same for waybar, the tray used the default icons instead of the selected icon theme.

Things done

Adding wrapGAppsHook fixes the style and icons for pavucontrol and waybar.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc

@ofborg ofborg bot requested review from abbradar and globin November 17, 2019 11:35
@vikanezrimaya
Copy link
Member

Wow, never noticed it in pavucontrol but definitely wondered why doesn't Waybar use my icons. (Used it in the past) I think I could find another app or two that don't use icons correctly on my machine.

@jtojnar
Copy link
Contributor

jtojnar commented Nov 20, 2019 •
edited

Could you describe the system you are running (DE/WM/possibly a config)? I do not understand why should this be necessary if you already have an icon theme installed – GTK picks up themes from XDG_DATA_DIRS, so when you have an icon theme in environment.systemPackages, it should find it.

Edit: never mind, I guess it is GDK_PIXBUF_MODULE_FILE variable the hook sets to include librsvg module.

@Flakebi
Copy link
Member Author

Flakebi commented Jan 13, 2020

Any news on this?
I’m using the patched packages since a few months now and didn’t notice issues.
So, can it be merged?

Thanks!

@jtojnar jtojnar merged commit 078f33b into NixOS:master Jan 14, 2020
@Flakebi Flakebi deleted the style branch January 14, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@vikanezrimaya vikanezrimaya vikanezrimaya approved these changes

@abbradar abbradar Awaiting requested review from abbradar

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Flakebi @vikanezrimaya @jtojnar